-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support trimming any text lines preceding the line containing the conventional commit type #416
feat: support trimming any text lines preceding the line containing the conventional commit type #416
Conversation
@albertocsm I'll take a look at this asap. Really appreciate the contribution and it looks like a useful addition |
@albertocsm, can you please rebase your branch? Thanks. |
16c5b62
to
a4f9f6f
Compare
done. |
…he conventional commit type
a4f9f6f
to
177bd0f
Compare
{ | ||
"skipPrerelease": [ | ||
"multiline" | ||
"skipPrerelease" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is not related to this PR goal but it looked like a "typo". please confirm this is the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great spot. This should be:
{
"required": [
"skipPrerelease"
]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix this shortly. The change looks great, and I don't want this to hold up merging this PR.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
+ Coverage 80.07% 81.80% +1.73%
==========================================
Files 40 42 +2
Lines 1977 1638 -339
==========================================
- Hits 1583 1340 -243
+ Misses 292 192 -100
- Partials 102 106 +4 ☔ View full report in Codecov by Sentry. |
impl proposal for #415