Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support trimming any text lines preceding the line containing the conventional commit type #416

Merged

Conversation

albertocsm
Copy link
Contributor

impl proposal for #415

@albertocsm albertocsm requested a review from ga-paul-t as a code owner June 17, 2024 15:45
@ga-paul-t
Copy link
Collaborator

@albertocsm I'll take a look at this asap. Really appreciate the contribution and it looks like a useful addition

@ga-paul-t
Copy link
Collaborator

@albertocsm, can you please rebase your branch? Thanks.

@albertocsm albertocsm force-pushed the feat_support_trimming_commit_header branch from 16c5b62 to a4f9f6f Compare June 25, 2024 09:40
@albertocsm
Copy link
Contributor Author

albertocsm commented Jun 25, 2024

@albertocsm, can you please rebase your branch? Thanks.

done.
also, ive noticed my commit is not signed. ill take care of that as well.

@albertocsm albertocsm force-pushed the feat_support_trimming_commit_header branch from a4f9f6f to 177bd0f Compare June 25, 2024 10:25
{
"skipPrerelease": [
"multiline"
"skipPrerelease"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is not related to this PR goal but it looked like a "typo". please confirm this is the case.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot. This should be:

{
  "required": [
     "skipPrerelease"
  ]
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this shortly. The change looks great, and I don't want this to hold up merging this PR.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 62.85714% with 13 lines in your changes missing coverage. Please review.

Project coverage is 81.80%. Comparing base (3b85254) to head (177bd0f).
Report is 29 commits behind head on main.

Files Patch % Lines
internal/semver/parser.go 72.22% 2 Missing and 3 partials ⚠️
internal/task/changelog/changelog.go 50.00% 3 Missing and 1 partial ⚠️
cmd/uplift/changelog.go 50.00% 1 Missing and 1 partial ⚠️
cmd/uplift/release.go 50.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   80.07%   81.80%   +1.73%     
==========================================
  Files          40       42       +2     
  Lines        1977     1638     -339     
==========================================
- Hits         1583     1340     -243     
+ Misses        292      192     -100     
- Partials      102      106       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ga-paul-t ga-paul-t merged commit 178aa79 into gembaadvantage:main Jun 26, 2024
8 of 9 checks passed
@albertocsm albertocsm deleted the feat_support_trimming_commit_header branch July 9, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants